Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse COPY INTO stage names without parens for SnowFlake #1187

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

mobuchowski
Copy link
Contributor

COPY INTO should not assume that parens surround Snowflake's stage names.

@coveralls
Copy link

coveralls commented Mar 18, 2024

Pull Request Test Coverage Report for Build 8422838438

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 87.892%

Totals Coverage Status
Change from base Build 8411261926: 0.01%
Covered Lines: 20506
Relevant Lines: 23331

💛 - Coveralls

Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowski mobuchowski force-pushed the fix_snowflake_stage_no_parens branch from b21e064 to 7093411 Compare March 25, 2024 15:41
@alamb alamb changed the title snowflake: copy_into correctly parses stage names without parens Fix parse COPY INTO stage names without parens for SnowFlake Apr 7, 2024
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @mobuchowski

Sorry for the delay in reviewing

@alamb alamb merged commit 17ef71e into sqlparser-rs:main Apr 7, 2024
10 checks passed
JichaoS pushed a commit to luabase/sqlparser-rs that referenced this pull request May 7, 2024
…rser-rs#1187)

Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants