Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for $$ in generic dialect ... #1185

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Add support for $$ in generic dialect ... #1185

merged 2 commits into from
Mar 24, 2024

Conversation

milenkovicm
Copy link
Contributor

... in create function

closes #1183

@milenkovicm
Copy link
Contributor Author

Hey @alamb this is follow up on #1159, can you please have a look when you get chance. Thanks!

alamb
alamb approved these changes Mar 24, 2024
View reviewed changes
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @milenkovicm

@coveralls
Copy link

coveralls commented Mar 24, 2024 •
edited

Pull Request Test Coverage Report for Build 8410133512

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 87.881%
Totals Coverage Status
Change from base Build 8266982631: 0.01%
Covered Lines: 20486
Relevant Lines: 23311
💛 - Coveralls

@alamb alamb merged commit 4472789 into sqlparser-rs:main Mar 24, 2024
10 checks passed
@milenkovicm milenkovicm deleted the generic_double_dollar_fix branch March 24, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for $$ in CREATE FUNCTION for generic dialect
3 participants
@milenkovicm @coveralls @alamb