-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support [FIRST | AFTER column_name]
support in ALTER TABLE
for MySQL
#1180
Support [FIRST | AFTER column_name]
support in ALTER TABLE
for MySQL
#1180
Conversation
src/parser/mod.rs
Outdated
@@ -5275,10 +5275,22 @@ impl<'a> Parser<'a> { | |||
}; | |||
|
|||
let column_def = self.parse_column_def()?; | |||
|
|||
let mut column_position = None; | |||
if dialect_of!(self is MySqlDialect) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per Contributing Guide, this is a dialect specific feature, shold also include GenericDialect
here.
36505d4
to
f52e326
Compare
f52e326
to
c823970
Compare
@andygrove Hi, could you please help approve the waiting workflow? |
Pull Request Test Coverage Report for Build 8308807027Details
💛 - Coveralls |
Had some fix and running workflow locally with result: codestyle
lint
compile
test
@andygrove sorry but could you please help approve the workflow again? |
[FIRST | AFTER column_name]
support in ALTER TABLE
for MySQL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @xring -- this is a very nice contribution. I think it is well tested, documented and implemented 🙏
Sorry for the delay in reviewing |
As per MySQL doc, the
ALTER TABLE Statement
has the definition:issue reported in #1172 , this PR add
[FIRST | AFTER column_name]
support in MySQL alter table