BigQuery: support unquoted hyphen in table/view declaration #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for proper object name parsing in bigquery to within a `CREATE TABLE` or `CREATE VIEW` statement. Similar to the parsing logic for when the table/view is later referenced. The lacking part was that bigquery allows unquoted hyphens in the first part of an object name - so that e.g. `CREATE TABLE my-project.mydataset.mytable` wasn't being parsed correctly.
Pull Request Test Coverage Report for Build 8278999704Details
💛 - Coveralls |
alamb
approved these changes
Apr 9, 2024
9 tasks
JichaoS
pushed a commit
to luabase/sqlparser-rs
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for proper object name parsing in bigquery to within a
CREATE TABLEorCREATE VIEWstatement. Similar to the parsing logic for when the table/view is later referenced.The lacking part was that bigquery allows unquoted hyphens in the first part of an object name - so that e.g.
CREATE TABLE my-project.mydataset.mytablewasn't being parsed correctly.