Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support postgres style CREATE FUNCTION in GenericDialect #1159

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Support postgres style CREATE FUNCTION in GenericDialect #1159

merged 2 commits into from
Mar 1, 2024

Conversation

alamb
Copy link
Collaborator

@alamb alamb commented Feb 29, 2024 •
edited

we found in apache/datafusion#9333 that GenericDialect does not support CREATE FUNCTION which is used by default

Thus support parsing posgres style CREATE FUNCTION in GenericDialect as well

@alamb alamb changed the title Support CREATE FUNCTION in GenericDialect Support postgres style CREATE FUNCTION in GenericDialect Feb 29, 2024
@alamb alamb mentioned this pull request Feb 29, 2024
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8102387775

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.914%
Totals Coverage Status
Change from base Build 8101836156: 0.0%
Covered Lines: 20266
Relevant Lines: 23052
💛 - Coveralls

@alamb alamb merged commit 9db9d22 into sqlparser-rs:main Mar 1, 2024
10 checks passed
@milenkovicm milenkovicm mentioned this pull request Mar 24, 2024
Merged
@alamb alamb deleted the alamb/create_function_generic branch April 9, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alamb @coveralls