ISSUE-1147: Add support for MATERIALIZED CTEs #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Postgres, the [NOT] MATERIALIZED keywords can be applied when creating CTEs. Add support for them.
Pull Request Test Coverage Report for Build 8095954676Details
💛 - Coveralls |
alamb
reviewed
Feb 29, 2024
src/ast/query.rs
Outdated
| #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))] | ||
| pub enum CteAsMaterialized { | ||
| /// The WITH statement does not specify MATERIALIZED behavior | ||
| Default, |
There was a problem hiding this comment.
Most other places in sqlparser-rs use Option<..> to represent the case when a clause is not present.
Since I had this branch checked out locally to resolve a merge conflict, I went ahead and made that change as well in 6df536a
There was a problem hiding this comment.
Ah for sure!
This route means we should remove the Default enum member though because now it's not useful, and if it does get added at some point it'll print with extra whitespace.
Mind if I add a commit to the PR doing so?
There was a problem hiding this comment.
Sure -- go ahead. I think I did remove CteAsMaterialized::Default in 6df536a though
There was a problem hiding this comment.
Ah nevermind, so you did. I misread it. Thanks!
alamb
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Postgres, the [NOT] MATERIALIZED keywords can be applied when creating CTEs. Add support for them.