Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support = operator in function args #1128

Merged

Conversation

universalmind303
Copy link
Contributor

closes #1057

Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @universalmind303 -- this looks great to me

#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
/// Operator used to separate function arguments
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Operator used to separate function arguments
/// Operator used to separate named function arguments

@coveralls
Copy link

coveralls commented Feb 9, 2024

Pull Request Test Coverage Report for Build 7838313913

  • -3 of 45 (93.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 87.675%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 8 9 88.89%
src/parser/mod.rs 10 12 83.33%
Totals Coverage Status
Change from base Build 7838299826: 0.01%
Covered Lines: 19612
Relevant Lines: 22369

💛 - Coveralls

@alamb
Copy link
Collaborator

alamb commented Feb 9, 2024

I think the CI check is failing due to the new Rust version that was released recently. I will fix that

@alamb
Copy link
Collaborator

alamb commented Feb 9, 2024

I merged up from main to pick up #1130

@alamb alamb merged commit d981b09 into sqlparser-rs:main Feb 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support = assignment in function args
3 participants