Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add duckdb "INSTALL" and "LOAD" #1127

Merged

Conversation

universalmind303
Copy link
Contributor

adds support for parsing duckdbs extension syntax. INSTALL [extension] and LOAD [extension]

Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @universalmind303

@coveralls
Copy link

coveralls commented Feb 9, 2024

Pull Request Test Coverage Report for Build 7838351892

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • -2 of 30 (93.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 87.672%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 4 6 66.67%
Totals Coverage Status
Change from base Build 7838299826: 0.007%
Covered Lines: 19600
Relevant Lines: 22356

💛 - Coveralls

@alamb
Copy link
Collaborator

alamb commented Feb 9, 2024

I merged up from main to pick up #1130 and make some small fixes to get CI to pass (as I had it downloaded anyways)

@alamb alamb merged commit a5ac425 into sqlparser-rs:main Feb 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants