Align Swagger-UI Prefix Path with Swagger-WebMvc Behavior #2862
+209
−244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your build is failing and looks like be creating multiple regressions. |
abdelmoez-guetat
force-pushed
the
fix-swaggerui-webflux-url
branch
from
181c64c to
bb0405c
Compare
|
I updated the code and fixed the tests |
|
Thank you for your contribution to the project. |
|
@abdelmoez-guetat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the Swagger-UI prefix path behavior in the springdoc-openapi-starter-webflux-ui module to align it with the behavior of springdoc-openapi-starter-webmvc-ui. With this update, the Swagger-UI will be accessible at /swagger-ui/index.html instead of /webjars/swagger-ui/index.html.
Key Changes:
Updated Resource Handler Path:
Changed the resource handler registration to use the SWAGGER_UI_PREFIX constant, ensuring that Swagger-UI assets are now served from /swagger-ui/ instead of /webjars/swagger-ui/.
Removed Unused Dependencies:
Eliminated the SpringDocConfigProperties parameter from the SwaggerWebFluxConfigurer constructor and related references, simplifying the configuration.
Unified Behavior:
Standardized the path prefix behavior to match that of springdoc-openapi-starter-webmvc-ui, making the behavior consistent across different SpringDoc modules.
Code Cleanup:
Refactored imports, removed unused parameters, and improved formatting for clarity and maintainability.