Using both generated and configured specs stoped working in 1.6.5 #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornblomqvist
changed the title
|
@bnasslahsen what do you think about this pull request? |
bjornblomqvist
force-pushed
the
using-both-generated-and-configured-specs-no-longer-works
branch
from
2214fc7
to
de848d4
Compare
|
The only change was to rebase on latest master |
I don't fully understand the fix but forcing SpringBootTest runner to not reuse the context solves the issue with SpringDocApp1451Test.java always failing with the following. "WebClientRequestException: Connection refused: localhost/127.0.0.1:9086" BUGFIX
Being able to use both a spec file and generated spec stopped working in version 1.6.5. The test shows the behavior found 1.6.4 and the fix brings back that behavior. BUGFIX
bjornblomqvist
force-pushed
the
using-both-generated-and-configured-specs-no-longer-works
branch
from
de848d4
to
41a988e
Compare
|
Last force push was to remove my employers email address. |
|
@bnasslahsen have you had time to look at this yet? |
|
Not yet. |
|
Thank you @bjornblomqvist for your PR. |
bnasslahsen
added a commit
that referenced
this pull request
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, prior to version 1.6.5 I could you use both a spec file and generated spec from annotations. This behavior is something I need to be able to upgrade to a later version. I am not sure if this feature that I have been using was even ment to work but it did and I would very much appreciate if we could bring it back.
You can find in this pull request a test and a fix for my problem. I think I put the test in the wrong place so I would appreciate if you could help me improve the test. Also as I don't know the code I think the fix might also be in the wrong place.
Best regards
Björn Blomqvist