Skip to content

Add TestBytes #16461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Jan 21, 2025 · 0 comments
Closed

Add TestBytes #16461

rwinch opened this issue Jan 21, 2025 · 0 comments
Assignees
@rwinch
Labels
in: build An issue in the build type: task A general task
Milestone
6.4.3

Comments

@rwinch
Copy link
Member

rwinch commented Jan 21, 2025

It is best if we avoid using Bytes.random in tests to ensure we have predictable tests. To make this easy, we TestBytes.get() should return a constant Bytes object and all tests should use it.
@rwinch rwinch added in: build An issue in the build type: task A general task labels Jan 21, 2025
@rwinch rwinch added this to the 6.4.3 milestone Jan 21, 2025
@rwinch rwinch self-assigned this Jan 21, 2025
@rwinch rwinch mentioned this issue Jan 21, 2025
Closed
@rwinch rwinch closed this as completed in 3209930 Jan 21, 2025
@rwinch rwinch mentioned this issue Jan 21, 2025
Closed
kwondh5217 pushed a commit to kwondh5217/spring-security that referenced this issue Feb 4, 2025
@rwinch @kwondh5217
Add TestBytes
5d96921 
Closes spring-projectsgh-16461

Signed-off-by: Daeho Kwon <trewq231@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: build An issue in the build type: task A general task
Projects
None yet
Milestone
6.4.3
Development

No branches or pull requests
1 participant
@rwinch