Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RememberMe docs #11450

Closed
marcusdacoregio opened this issue Jun 30, 2022 · 7 comments
Closed

Improve RememberMe docs #11450

marcusdacoregio opened this issue Jun 30, 2022 · 7 comments
Assignees
@marcusdacoregio @petrovskimario
Labels
in: docs An issue in Documentation or samples status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement

Comments

@marcusdacoregio
Copy link
Contributor

The RememberMe docs is pretty light on configuration samples, there are only XML configuration fragments.

It should be improved with at least a more modern way to configure it, using Java Configuration and defining the Beans from a Java class.
@marcusdacoregio marcusdacoregio added in: docs An issue in Documentation or samples type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Jun 30, 2022
@priya1712d
Copy link

Hello!
Can I work on this?

@marcusdacoregio
Copy link
Contributor Author

Hi @priya1712d, of course, the ticket is yours!

Feel free to ask any questions about the solution here.

@cotnic
Copy link
Contributor

cotnic commented Dec 5, 2022

Hello @marcusdacoregio, it seems this issue is not being worked on. Could I take it over?

@marcusdacoregio
Copy link
Contributor Author

Hello @cotnic. It's been a while since we had an update about this.

@cotnic I think it should be fine for you to work on this. If @priya1712d is still willing to work on this issue you can both work on the doc and the PR review.

@petrovskimario
Copy link
Contributor

Is this resolved ?
If not i can pick this up

@marcusdacoregio
Copy link
Contributor Author

Hi @petrovskimario, this is not resolved yet.

It became stale because we have not had any updates from @cotnic and @priya1712d.
I'll assign it to you then. Thanks!

petrovskimario pushed a commit to petrovskimario/spring-security-contribution that referenced this issue Jul 4, 2023
Closes spring-projects#11450
7d439cb 
Added configuration with Java beans where XML was only provided.
@petrovskimario
Copy link
Contributor

Hello @marcusdacoregio
I have submitted a pull request which provides the Java beans configuration.
Please review and if you have any suggestions for improving, let me know.

petrovskimario pushed a commit to petrovskimario/spring-security-contribution that referenced this issue Jul 20, 2023
Closes spring-projects#11450 Add Java beans configuration for Remmemb…
d73dc14 
…er Me Docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

@petrovskimario petrovskimario

Labels
in: docs An issue in Documentation or samples status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cotnic @marcusdacoregio @priya1712d @petrovskimario