Skip to content

Optimization around constructing UriTemplate with multiple template variables of the same type #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odrotbohm opened this issue Jun 1, 2022 · 1 comment
Closed

Optimization around constructing UriTemplate with multiple template variables of the same type #1797

odrotbohm opened this issue Jun 1, 2022 · 1 comment
Assignees
@odrotbohm
Labels
in: core Core parts of the project type: enhancement
Milestone
1.5.1

Comments

@odrotbohm
Copy link
Member

No description provided.

@odrotbohm odrotbohm added type: enhancement in: core Core parts of the project labels Jun 1, 2022
@odrotbohm odrotbohm added this to the 1.5.1 milestone Jun 1, 2022
@odrotbohm odrotbohm self-assigned this Jun 1, 2022
odrotbohm pushed a commit that referenced this issue Jun 1, 2022
@MikeRocke @odrotbohm
#1797 - Optimization around constructing UriTemplate when supplying T…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
a53860a 
…emplateVariables of same type

Reduce the repeated merge routines on ExpandGroups.

Before:
Benchmark                          Mode  Cnt     Score     Error  Units
TemplateVariableBenchmark.concat  thrpt    3  3150,261 ± 263,525  ops/s

After:
Benchmark                          Mode  Cnt      Score      Error  Units
TemplateVariableBenchmark.concat  thrpt    3  55275,436 ± 3778,690  ops/s
odrotbohm added a commit that referenced this issue Jun 1, 2022
@odrotbohm
#1797 - Polishing.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
35c76e9 
Avoid grouping of template variables via stream.

Before:

Benchmark                          Mode  Cnt      Score      Error  Units
TemplateVariableBenchmark.concat  thrpt    3  55275,436 ± 3778,690  ops/s

After:

Benchmark                          Mode  Cnt      Score     Error  Units
TemplateVariableBenchmark.concat  thrpt    3  64587,790 ± 735,705  ops/s
@odrotbohm
Copy link
Member Author

Backport of #1775.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Core parts of the project type: enhancement
Projects
None yet
Milestone
1.5.1
Development

No branches or pull requests
1 participant
@odrotbohm