Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements in TemplateVariable.essence() #1765

Closed
odrotbohm opened this issue Apr 14, 2022 · 0 comments
Closed

Performance improvements in TemplateVariable.essence() #1765

odrotbohm opened this issue Apr 14, 2022 · 0 comments
Assignees
@odrotbohm
Labels
in: core Core parts of the project type: enhancement
Milestone
1.5 RC1

Comments

@odrotbohm
Copy link
Member

Backport of #1764.
@odrotbohm odrotbohm added type: enhancement in: core Core parts of the project labels Apr 14, 2022
@odrotbohm odrotbohm added this to the 1.5 M3 milestone Apr 14, 2022
@odrotbohm odrotbohm self-assigned this Apr 14, 2022
odrotbohm added a commit that referenced this issue Apr 14, 2022
@odrotbohm
#1765 - Performance tweaks in TemplateVariable.toString(…).
7853402 
Heavily inspired by the PR @MikeRocke, we removed all usage of String.format(…) from hot code paths triggered by ….toString() as it's used in general output a lot.

Before:

Benchmark                                    Mode  Cnt         Score        Error  Units
TemplateVariableBenchmark.toString(…)       thrpt    3   2803239,270 ± 110258,955  ops/s

After:

Benchmark                                    Mode  Cnt         Score        Error  Units
TemplateVariableBenchmark.toString(…)       thrpt    3  10753653,459 ± 156684,459  ops/s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Core parts of the project type: enhancement
Projects
None yet
Milestone
1.5 RC1
Development

No branches or pull requests
1 participant
@odrotbohm