Skip to content

SseBuilder in ServerResponse should allow empty comment #34608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rstoyanchev opened this issue Mar 17, 2025 · 0 comments
Closed

SseBuilder in ServerResponse should allow empty comment #34608

rstoyanchev opened this issue Mar 17, 2025 · 0 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.2.5

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Mar 17, 2025 •
edited
Loading

SseBuilder#comment expects the comment to have length. However, an empty comment is accepted and is commonly sent as a keepalive message.

The spec has this for the ABNF:

comment = colon *any-char end-of-line

And also for parsing guidelines:

If the line starts with a U+003A COLON character (:)
Ignore the line.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug labels Mar 17, 2025
@rstoyanchev rstoyanchev added this to the 6.2.5 milestone Mar 17, 2025
@rstoyanchev rstoyanchev self-assigned this Mar 17, 2025
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed type: bug A general bug labels Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.5
Development

No branches or pull requests
1 participant
@rstoyanchev