Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove use of UrlPathHelper in ServletWebSocketHandlerRegistry #34508

Closed
rstoyanchev opened this issue Feb 27, 2025 · 0 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

Spring Security is preparing to adapt to the PathMatcher deprecations in spring-web, see spring-projects/spring-security#16499. A question came up how to adapt to the deprecation of UrlPathHelper use in ServletWebSocketHandlerRegistry.

The WebSocketHandlerMapping is created internally, and there is no mechanism to customize it. Therefore, after PathPatternParser became the default, the UrlPathHelper property is effectively no longer used. We can fastrack its removal in 7.0 with an immediate deprecation in 6.2.x.

@rstoyanchev rstoyanchev self-assigned this Feb 27, 2025
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Feb 27, 2025
@rstoyanchev rstoyanchev added this to the 6.2.4 milestone Feb 27, 2025
rstoyanchev added a commit that referenced this issue Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant