Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load-time weaving support for WildFly 24+ #33728

Closed
mkoskin opened this issue Oct 17, 2024 · 3 comments
Closed

Load-time weaving support for WildFly 24+ #33728

mkoskin opened this issue Oct 17, 2024 · 3 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
6.1.15

Comments

@mkoskin
Copy link

mkoskin commented Oct 17, 2024

Support for wildfly delegating transformer is broken since wildfly-core 19 wildfly/wildfly-core@c0d7756

Spring class org.springframework.instrument.classloading.jboss.JBossLoadTimeWeaver expects to load class org.jboss.as.server.deployment.module.DelegatingClassFileTransformer. However, this class has been renamed to org.jboss.as.server.deployment.module.DelegatingClassTransformer in wildfly-server 19.0.0. Also, the DelegatingClassTransformer doesn't implement java.lang.instrument.ClassFileTransformer any more. Instead, it implements org.jboss.modules.ClassTransformer.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 17, 2024
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 17, 2024
@jhoeller jhoeller self-assigned this Oct 18, 2024
@jhoeller jhoeller modified the milestones: 6.2.0, 6.1.15 Oct 18, 2024
@jhoeller
Copy link
Contributor

I've added conditional support for WildFly 24+ to JBossLoadTimeWeaver. This will be available in the upcoming 6.1.15 and 6.2.0 snapshots; feel free to give it an early try. Note that this has not been tested in an actual WildFly deployment yet, so any such test would be highly appreciated.

@mkoskin
Copy link
Author

mkoskin commented Oct 22, 2024

I tested this with 6.1.15 snapshot together with WildFly 31.0.1.Final and EclipseLink 4.0.4 with load time weaving enabled. This combination is now working correctly. Thank you!

@jhoeller
Copy link
Contributor

Good to hear! Thanks for the immediate feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.15
Development

No branches or pull requests
3 participants
@jhoeller @spring-projects-issues @mkoskin