-
Notifications
You must be signed in to change notification settings - Fork 38.4k
ReactorNettyClientResponse should not throw exception if no body is available #32805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
The server was the cause of the problem, not RestClient. |
It seems that the RestClient is still the cause of the problem, so we will reopen. Example of fix (Java 11 or higher): @Override
public InputStream getBody() throws IOException {
InputStream body = this.body;
if (body != null) {
return body;
}
body = this.connection.inbound().receive()
.aggregate().asInputStream().block(this.readTimeout);
if (body == null) {
// throw new IOException("Could not receive body");
body = InputStream.nullInputStream();
}
this.body = body;
return body;
} |
See comment in #32934 |
Sorry, I didn't know if reopen or repost was better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment: Spring Web 6.1.6, Java 17
The situation is the same as in #31719, which occurs when using Reactor Netty.
The reason is that the following code throws an exception:
https://github.com/spring-projects/spring-framework/blob/v6.1.6/spring-web/src/main/java/org/springframework/http/client/ReactorNettyClientResponse.java#L85
I believe that null should also be returned when using Reactor Netty, please let me know about a better way to implement this.
Thanks
The text was updated successfully, but these errors were encountered: