Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CronTrigger hard-codes default ZoneId instead of participating in scheduler-wide Clock setup #31948

Closed
jhoeller opened this issue Jan 4, 2024 · 0 comments
Closed

CronTrigger hard-codes default ZoneId instead of participating in scheduler-wide Clock setup #31948

jhoeller opened this issue Jan 4, 2024 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
6.1.3

Comments

@jhoeller
Copy link
Contributor

jhoeller commented Jan 4, 2024

Along with #19475, it turned out that CronTrigger hard-codes the system ZoneId by default while it should really take it from TriggerContext.getClock().getZone() - which is the system ZoneId by default as well but participates in scheduler-wide Clock customization (which we introduced in 5.3).
@jhoeller jhoeller added type: bug A general bug in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 4, 2024
@jhoeller jhoeller added this to the 6.1.3 milestone Jan 4, 2024
@jhoeller jhoeller self-assigned this Jan 4, 2024
@jhoeller jhoeller added the for: backport-to-6.0.x Marks an issue as a candidate for backport to 6.0.x label Jan 4, 2024
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-6.0.x Marks an issue as a candidate for backport to 6.0.x labels Jan 4, 2024
@github-actions github-actions bot mentioned this issue Jan 4, 2024
Closed
@jhoeller jhoeller added the for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x label Jan 4, 2024
@github-actions github-actions bot removed the for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x label Jan 4, 2024
@github-actions github-actions bot mentioned this issue Jan 4, 2024
Closed
jhoeller added a commit that referenced this issue Jan 5, 2024
@jhoeller
Default time zone resolution from scheduler-wide Clock
d074f66 
Closes gh-31948
jhoeller added a commit that referenced this issue Jan 5, 2024
@jhoeller
Default time zone resolution from scheduler-wide Clock
c1db06a 
Closes gh-31948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
6.1.3
Development

No branches or pull requests
1 participant
@jhoeller