Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JdkClientHttpRequest may block indefinitely #31911

Closed
haavar opened this issue Dec 27, 2023 · 0 comments
Closed

JdkClientHttpRequest may block indefinitely #31911

haavar opened this issue Dec 27, 2023 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@haavar
Copy link

haavar commented Dec 27, 2023

Affects: 6


When using JdkClientHttpRequestFactory the request may block indefinitely, even if a request timeout is configured.

Details about the issue:

This is the problematic line, that should be updated to an async call with an immediate get on the CompletableFuture:

this.httpClient.send(request, HttpResponse.BodyHandlers.ofInputStream());

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 27, 2023
@sbrannen sbrannen changed the title JdkClientHttpRequest may block indefinitely JdkClientHttpRequest may block indefinitely Dec 28, 2023
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Dec 28, 2023
@poutsma poutsma self-assigned this Jan 8, 2024
@poutsma poutsma added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 9, 2024
@poutsma poutsma added this to the 6.1.3 milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants