PathResourceResolver.getResource() does not log warning if Resource#getURL() throws exception
#31623
Assignees
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
status: backported
An issue that has been backported to maintenance branches
type: bug
A general bug
Milestone
Comments
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
the
in: web
sbrannen
changed the title
PathResourceResolver.getResource() never logs a warning for non-existent ServletContextResource
sbrannen
added
type: bug
|
Hi @matthiaskraaz, Congratulations on reporting your first issue for the Spring Framework! 👍 I have a fix prepared locally, and we'll make sure to include it in the next release. |
sbrannen
added
the
for: backport-to-6.0.x
github-actions
bot
added
status: backported
sbrannen
changed the title
PathResourceResolver.getResource() never logs a warning for non-existent ServletContextResourcePathResourceResolver.getResource() does not log warning if Resource#getURL() throws exception
sbrannen
added a commit
that referenced
this issue
Nov 20, 2023
Prior to this commit, the getResource() methods in PathResourceResolver implementations allowed an exception thrown from Resource#getURL() to propagate instead of logging a warning about the missing resource as intended. This commit modifies the getResource() methods in PathResourceResolver implementations so that the log messages include the output of the toString() implementations of the underlying resources instead of their getURL() implementations, which may throw an exception. Furthermore, logging the toString() output of resources aligns with the existing output for "allowed locations" in the same log message. Note that the toString() implementations could potentially also throw exceptions, but that is considered less likely. See gh-31623 Closes gh-31624 (cherry picked from commit 7d2ea7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If
ServletContextResource.getURL()throws aFileNotFoundExceptionbecauseServletContext.getResource(String)returnsnull, thenorg.springframework.web.servlet.resource.PathResourceResolver.getResource(String, Resource)does not log a warning as intended.The text was updated successfully, but these errors were encountered: