Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine CRaC restoration logs #31462

Closed
sdeleuze opened this issue Oct 20, 2023 · 0 comments
Closed

Refine CRaC restoration logs #31462

sdeleuze opened this issue Oct 20, 2023 · 0 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@sdeleuze
Copy link
Contributor

As discussed with @wilkinsona, we should refine CRaC restoration logs in order to ensure consistency with Spring Boot and avoid duplicated and inconsistent logging.

With the changes introduced by this issue, the logs for on demand checkpoint/restore of a running application will be:

Restarting Spring-managed lifecycle beans after JVM restore
Tomcat started on port 8080 (http) with context path ''
Spring-managed lifecycle restart completed (restored JVM running for 181 ms)

The logs for automatic checkpoint/restore at startup will be:

Restarting Spring-managed lifecycle beans after JVM restore
Tomcat started on port 8080 (http) with context path ''
Restored Application in 0.11 seconds (process running for 0.112)
@sdeleuze sdeleuze added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Oct 20, 2023
@sdeleuze sdeleuze added this to the 6.1.0-RC2 milestone Oct 20, 2023
@sdeleuze sdeleuze self-assigned this Oct 20, 2023
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant