Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not delegate TRACE to HttpServlet on ERROR dispatch #31457

Closed
rstoyanchev opened this issue Oct 18, 2023 · 0 comments
Closed

Do not delegate TRACE to HttpServlet on ERROR dispatch #31457

rstoyanchev opened this issue Oct 18, 2023 · 0 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.0.14

Comments

@rstoyanchev
Copy link
Contributor

Based on spring-projects/spring-boot#33623.

Tomcat disables TRACE requests by default, which results in a 405. Spring Boot handles the resulting ERROR dispatch, and FrameworkServlet delegates to its parent for doTrace handling as usual. The result is in an error response with HTTP TRACE (instead of error) details in the body.

The issue will be fixed at the Servlet level with jakartaee/servlet#545, possibly for Servlet 6.1, but meanwhile we can apply a temporary fix in FrameworkServlet.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Oct 18, 2023
@rstoyanchev rstoyanchev added this to the 6.0.14 milestone Oct 18, 2023
@rstoyanchev rstoyanchev self-assigned this Oct 18, 2023
@wilkinsona wilkinsona mentioned this issue Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.14
Development

No branches or pull requests
1 participant
@rstoyanchev