Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultipartParser should respect read position #31110

Closed
sdeleuze opened this issue Aug 24, 2023 · 3 comments
Closed

MultipartParser should respect read position #31110

sdeleuze opened this issue Aug 24, 2023 · 3 comments
Assignees
@poutsma
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone
6.0.13

Comments

@sdeleuze
Copy link
Contributor

As a follow-up for #31095, we should explore potentially with @violetagg why Spring multipart tests fail with Reactor Netty 2. Could be due to Netty 5 adding additional EOL characters, see below the typical error we observe:

expected: 
  "FormBean[fieldValue,[fileParts:foo.txt,fileParts:logo.png]]"
 but was: 
  "FormBean[fieldValue
  ,[fileParts:foo.txt,fileParts:logo.png]]"
@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task labels Aug 24, 2023
@sdeleuze sdeleuze added this to the 6.1.x milestone Aug 24, 2023
@violetagg
Copy link
Member

I'll check that

@violetagg
Copy link
Member

@sdeleuze I think that MultipartParser should handle the read position. See this change

violetagg@8f9de72

@poutsma poutsma self-assigned this Sep 12, 2023
@poutsma poutsma modified the milestones: 6.1.x, 6.0.13 Sep 15, 2023
@poutsma poutsma changed the title Determine why Reactor Netty 2 multipart tests fail MultipartParser should respect read position Sep 15, 2023
@poutsma poutsma added type: bug A general bug for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x and removed type: task A general task labels Sep 15, 2023
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x labels Sep 15, 2023
@github-actions github-actions bot mentioned this issue Sep 15, 2023
Closed
@poutsma poutsma removed the status: backported An issue that has been backported to maintenance branches label Sep 15, 2023
@poutsma
Copy link
Contributor

poutsma commented Sep 15, 2023 •
edited

In retrospect, it appears that this issue does not occur in 5.3.x, so #31240 was closed as invalid.

poutsma added a commit that referenced this issue Sep 15, 2023
@poutsma
MultipartParser should respect read position
8f13031 
This commit ensures that the MultipartParser takes a buffer's read
position into account.

Closes gh-31110
poutsma added a commit that referenced this issue Sep 15, 2023
@poutsma
Enable disabled multi-part Netty 2 tests
056de7e 
See gh-31110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Milestone
6.0.13
Development

No branches or pull requests
3 participants
@sdeleuze @poutsma @violetagg