Skip to content

Improve logging for missing dependencies in MicrometerObservationRegistryTestExecutionListener #30747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sbrannen opened this issue Jun 25, 2023 · 1 comment
Closed

Improve logging for missing dependencies in MicrometerObservationRegistryTestExecutionListener #30747

sbrannen opened this issue Jun 25, 2023 · 1 comment
Assignees
@sbrannen
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone
6.0.11

Comments

@sbrannen
Copy link
Member

See #30726 (comment) for details.
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement labels Jun 25, 2023
@sbrannen sbrannen added this to the 6.0.11 milestone Jun 25, 2023
@sbrannen sbrannen self-assigned this Jun 25, 2023
@sbrannen sbrannen mentioned this issue Jun 25, 2023
Closed
@sbrannen
Copy link
Member Author

This has been addressed in acb786d.

As stated in the commit comments, the following demonstrate the generated DEBUG message when ObservationThreadLocalAccessor or ThreadLocalAccessor is missing, respectively.

Skipping candidate TestExecutionListener [org.springframework.test.context.observation.MicrometerObservationRegistryTestExecutionListener] due to a missing dependency. Specify custom TestExecutionListener classes or make the default TestExecutionListener classes and their required dependencies available. Offending class: io.micrometer.observation.contextpropagation.ObservationThreadLocalAccessor. MicrometerObservationRegistryTestExecutionListener requires io.micrometer:micrometer-observation:1.10.8 or higher and io.micrometer:context-propagation:1.0.3 or higher.

Skipping candidate TestExecutionListener [org.springframework.test.context.observation.MicrometerObservationRegistryTestExecutionListener] due to a missing dependency. Specify custom TestExecutionListener classes or make the default TestExecutionListener classes and their required dependencies available. Offending class: io.micrometer.context.ThreadLocalAccessor. MicrometerObservationRegistryTestExecutionListener requires io.micrometer:micrometer-observation:1.10.8 or higher and io.micrometer:context-propagation:1.0.3 or higher.

@wilkinsona and @lynchie14, please let me know if the current behavior now meets your expectations.

@wilkinsona wilkinsona mentioned this issue Jul 1, 2023
Closed
sbrannen added a commit that referenced this issue Jul 2, 2023
@sbrannen
Check deps only once in MicrometerObservationRegistryTestExecutionLis…
5aac35b 
…tener

Prior to this commit, the required runtime dependencies were checked
via reflection each time an attempt was made to instantiate
MicrometerObservationRegistryTestExecutionListener.

Since it's sufficient to check for the presence of required runtime
dependencies only once, this commit caches the results of the
dependency checks in a static field.

This commit also introduces automated tests for the runtime dependency
checks in MicrometerObservationRegistryTestExecutionListener.

See gh-30747
@trydofor trydofor mentioned this issue Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.11
Development

No branches or pull requests
1 participant
@sbrannen