Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent ProxyCallbackFilter#equals/hashCode methods in CglibAopProxy #30615

Closed
jhoeller opened this issue Jun 8, 2023 · 0 comments
Closed

Inconsistent ProxyCallbackFilter#equals/hashCode methods in CglibAopProxy #30615

jhoeller opened this issue Jun 8, 2023 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
6.0.10

Comments

@jhoeller
Copy link
Contributor

jhoeller commented Jun 8, 2023

In the course of #26266, it turns out that the ProxyCallbackFilter.equals/hashCode methods are inconsistent and also not as efficient as they could be given the usage scenarios.
@jhoeller jhoeller added type: bug A general bug in: core Issues in core modules (aop, beans, core, context, expression) labels Jun 8, 2023
@jhoeller jhoeller added this to the 6.0.10 milestone Jun 8, 2023
@jhoeller jhoeller self-assigned this Jun 8, 2023
@jhoeller jhoeller changed the title Inconsistent ProxyCallbackFilter.equals/hashCode methods in CglibAopProxy Inconsistent ProxyCallbackFilter#equals/hashCode methods in CglibAopProxy Jun 8, 2023
@jhoeller jhoeller added the for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x label Jun 8, 2023
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x labels Jun 8, 2023
@github-actions github-actions bot mentioned this issue Jun 8, 2023
Closed
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@jhoeller @mdeinum
Reduce ProxyCallbackFilter to key-only role after class generation
19eb7eb 
Avoids memory leaks from ProxyCallbackFilter-contained Advisors.
Includes consistent ProxyCallbackFilter#equals/hashCode methods.

Closes spring-projectsgh-26266
Closes spring-projectsgh-30615
@sbrannen sbrannen mentioned this issue Aug 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
6.0.10
Development

No branches or pull requests
1 participant
@jhoeller