Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in ReactiveTransactionSupport.unwrapIfResourceCleanupFailure #30597

Closed
andruskutt opened this issue Jun 5, 2023 · 1 comment
Closed

NPE in ReactiveTransactionSupport.unwrapIfResourceCleanupFailure #30597

andruskutt opened this issue Jun 5, 2023 · 1 comment
Assignees
@jhoeller
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: regression A bug that is also a regression
Milestone
6.0.10

Comments

@andruskutt
Copy link

andruskutt commented Jun 5, 2023 •
edited

Affects: spring boot 3.0.7

in method unwrapIfResourceCleanupFailure of org.springframework.transaction.interceptor.TransactionAspectSupport.ReactiveTransactionSupport class
if ex.getMessage() returns null then we get NullPointerException:

			if (ex instanceof RuntimeException &&
					ex.getCause() != null &&
					ex.getMessage().startsWith("Async resource cleanup failed")) {
				return ex.getCause();
			}

https://github.com/spring-projects/spring-framework/blob/main/spring-tx/src/main/java/org/springframework/transaction/interceptor/TransactionAspectSupport.java#L1088
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 5, 2023
@jhoeller
Copy link
Contributor

jhoeller commented Jun 7, 2023

This seems to be a regression caused by #27572. To be revised for 6.0.10.

@jhoeller jhoeller self-assigned this Jun 7, 2023
@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) type: regression A bug that is also a regression and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 7, 2023
@jhoeller jhoeller added this to the 6.0.10 milestone Jun 7, 2023
@sbrannen sbrannen changed the title NPE in org.springframework.transaction.interceptor.TransactionAspectSupport.ReactiveTransactionSupport::unwrapIfResourceCleanupFailure NPE in TransactionAspectSupport.ReactiveTransactionSupport.unwrapIfResourceCleanupFailure Jun 7, 2023
@sbrannen sbrannen changed the title NPE in TransactionAspectSupport.ReactiveTransactionSupport.unwrapIfResourceCleanupFailure NPE in ReactiveTransactionSupport.unwrapIfResourceCleanupFailure Jun 7, 2023
@21lva 21lva mentioned this issue Jun 23, 2023
Closed
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jun 23, 2023
@sbrannen
Ignore null message when introspecting resource cleanup failure
9ccbeec 
This commit fixes a regression introduced in conjunction with spring-projectsgh-27572.

See spring-projectsgh-30597
Closes spring-projectsgh-30729
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@jhoeller @mdeinum
Ignore null message when introspecting resource cleanup failure
7b33f28 
Closes spring-projectsgh-30597
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@sbrannen @mdeinum
Ignore null message when introspecting resource cleanup failure
80a42f9 
This commit fixes a regression introduced in conjunction with spring-projectsgh-27572.

See spring-projectsgh-30597
Closes spring-projectsgh-30729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: regression A bug that is also a regression
Projects
None yet
Milestone
6.0.10
Development

No branches or pull requests
3 participants
@jhoeller @andruskutt @spring-projects-issues