Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle all exceptions for stored proc output param retrieval in SharedEntityManagerCreator #30164

Closed
github-actions bot opened this issue Mar 22, 2023 · 1 comment
Closed

Handle all exceptions for stored proc output param retrieval in SharedEntityManagerCreator #30164

github-actions bot opened this issue Mar 22, 2023 · 1 comment
Assignees
@sbrannen
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Milestone
5.3.27

Comments

@github-actions
Copy link

github-actions bot commented Mar 22, 2023 •
edited by sbrannen

Backport of gh-30161
@github-actions github-actions bot added in: data Issues in data modules (jdbc, orm, oxm, tx) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug labels Mar 22, 2023
@github-actions github-actions bot added this to the 5.3.27 milestone Mar 22, 2023
@sbrannen sbrannen changed the title Connection leak in HikariCP due to unhandled stored procedure output parameter exception SharedEntityManagerCreator does not handle all exceptions for stored proc output param retrieval Mar 22, 2023
@sbrannen sbrannen changed the title SharedEntityManagerCreator does not handle all exceptions for stored proc output param retrieval SharedEntityManagerCreator does not handle all exceptions for stored proc output param retrieval Mar 22, 2023
@sbrannen sbrannen self-assigned this Mar 22, 2023
@sbrannen sbrannen changed the title SharedEntityManagerCreator does not handle all exceptions for stored proc output param retrieval Handle all exceptions for stored proc output param retrieval in SharedEntityManagerCreator Mar 22, 2023
sbrannen pushed a commit that referenced this issue Mar 22, 2023
@giuseppemilicia @sbrannen
Handle all exceptions for stored proc out param retrieval in SharedEn…
a94c50e 
…tityManagerCreator

Prior to this commit, the EntityManager was not closed in
SharedEntityManagerCreator.DeferredQueryInvocationHandler's
invoke(Object, Method, Object[]) method if an invocation of
getOutputParameterValue(*) threw an exception other than
IllegalArgumentException, which could lead to a connection leak.

This commit addresses this by catching RuntimeException instead of
IllegalArgumentException.

Closes gh-30164
@sbrannen
Copy link
Member

Closed in a94c50e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Projects
None yet
Milestone
5.3.27
Development

No branches or pull requests
1 participant
@sbrannen