Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @DynamicPropertySource examples regarding changes in Testcontainers #29940

Closed
github-actions bot opened this issue Feb 7, 2023 · 3 comments
Closed

Update @DynamicPropertySource examples regarding changes in Testcontainers #29940

github-actions bot opened this issue Feb 7, 2023 · 3 comments
Assignees
@sbrannen
Labels
in: test Issues in the test module type: backport An issue that is a backport of another issue to a maintenance branch type: documentation A documentation task
Milestone
5.3.26

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Backport of gh-29939
@github-actions github-actions bot added in: test Issues in the test module type: backport An issue that is a backport of another issue to a maintenance branch type: documentation A documentation task labels Feb 7, 2023
@github-actions github-actions bot added this to the 5.3.26 milestone Feb 7, 2023
@sbrannen sbrannen self-assigned this Feb 7, 2023
@sbrannen
Copy link
Member

sbrannen commented Feb 7, 2023

Closed in 782ee34

@sbrannen sbrannen closed this as completed Feb 7, 2023
@sbrannen sbrannen mentioned this issue Feb 7, 2023
Closed
@sbrannen
Copy link
Member

sbrannen commented Feb 7, 2023

Reopening to address recommendation in #29939 (comment)

@sbrannen sbrannen reopened this Feb 7, 2023
sbrannen added a commit that referenced this issue Feb 7, 2023
@sbrannen
Revise Testcontainers examples based on feedback

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
c9841f3 
Closes gh-29940
@sbrannen
Copy link
Member

sbrannen commented Feb 7, 2023

Closed in c9841f3

@sbrannen sbrannen closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module type: backport An issue that is a backport of another issue to a maintenance branch type: documentation A documentation task
Projects
None yet
Milestone
5.3.26
Development

No branches or pull requests
1 participant
@sbrannen