Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include all Hibernate query methods in SharedEntityManagerCreator's queryTerminatingMethods set #29888

Closed
github-actions bot opened this issue Jan 26, 2023 · 1 comment
Closed

Include all Hibernate query methods in SharedEntityManagerCreator's queryTerminatingMethods set #29888

github-actions bot opened this issue Jan 26, 2023 · 1 comment
Assignees
@sbrannen
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Milestone
5.3.26

Comments

@github-actions
Copy link

Backport of gh-29886
@github-actions github-actions bot added in: data Issues in data modules (jdbc, orm, oxm, tx) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement labels Jan 26, 2023
@github-actions github-actions bot added this to the 5.3.26 milestone Jan 26, 2023
@sbrannen sbrannen self-assigned this Jan 26, 2023
@sbrannen sbrannen changed the title Hibernate Query#uniqueResult is not included in SharedEntityManagerCreator's queryTerminatingMethods set, causing DB connection leak Include all Hibernate query methods in SharedEntityManagerCreator's queryTerminatingMethods set Jan 27, 2023
sbrannen added a commit that referenced this issue Jan 28, 2023
@sbrannen
Include all Hibernate methods in SharedEntityManagerCreator's queryTe…
3d6d853 
…rminatingMethods

Prior to this commit, we included Hibernate's Query.list() method in
SharedEntityManagerCreator's queryTerminatingMethods set but did not
include all of Hibernate's query-terminating methods.

To address this, this commit additionally includes the stream(),
uniqueResult(), and uniqueResultOptional() methods from Hibernate's
Query API in SharedEntityManagerCreator's query-terminating methods set.

Closes gh-29888
@sbrannen
Copy link
Member

Closed in 3d6d853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.26
Development

No branches or pull requests
1 participant
@sbrannen