-
Notifications
You must be signed in to change notification settings - Fork 38.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Kotlin filter parameter bug in Router DSLs #26921
Comments
Co-authored-by: hojongs <hojong.jjh@gmail.com> Co-authored-by: bjh970913 <bjh970913@gmail.com> Closes spring-projectsgh-26921
Fixed via 3ab270e |
@sdeleuze @jhoeller @spring-projects |
I think that's because @sdeleuze included your work in his own commit (instead of merging your PR) and listed you as a co-author in the commit message as follows.
Are you one of those listed co-authors? If so, which one? |
I have manually added you as a contributor to the 5.3.7 release notes. |
Thanks ! |
You're welcome.
OK. I now see that you're listed as the author of commit 07ba957. So perhaps the script that generates our release notes did not automatically include you as a contributor since that commit referenced the original issue instead of your PR. But I am merely speculating. @snicoll, can you perhaps explain why that happened?
Sure. I'll add them to the release notes, too. Can you please confirm that their GitHub handles are @hojongs and @bjh970913? |
@sbrannen |
The tool does not parse commit messages at all. |
Backport of gh-26838
The text was updated successfully, but these errors were encountered: