Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kotlin filter parameter bug in Router DSLs #26921

Closed
spring-projects-issues opened this issue May 10, 2021 · 8 comments
Closed

Fix Kotlin filter parameter bug in Router DSLs #26921

spring-projects-issues opened this issue May 10, 2021 · 8 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Backport of gh-26838

@spring-projects-issues spring-projects-issues added in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug labels May 10, 2021
@spring-projects-issues spring-projects-issues added this to the 5.2.15 milestone May 10, 2021
sdeleuze pushed a commit to sdeleuze/spring-framework that referenced this issue May 10, 2021
Co-authored-by: hojongs <hojong.jjh@gmail.com>
Co-authored-by: bjh970913 <bjh970913@gmail.com>

Closes spring-projectsgh-26921
@spring-projects-issues
Copy link
Collaborator Author

Fixed via 3ab270e

@ShindongLee
Copy link

@sdeleuze @jhoeller @spring-projects
My PR was merged to 5.3.7 and 5.2.15 but my name is missing on contributors in 5.3.7 release note 😭
Please check 😭

@sbrannen
Copy link
Member

@sdeleuze @jhoeller @spring-projects
My PR was merged to 5.3.7 and 5.2.15 but my name is missing on contributors in 5.3.7 release note 😭

I think that's because @sdeleuze included your work in his own commit (instead of merging your PR) and listed you as a co-author in the commit message as follows.

Co-authored-by: hojongs <hojong.jjh@gmail.com>
Co-authored-by: bjh970913 <bjh970913@gmail.com>

Are you one of those listed co-authors? If so, which one?

@sbrannen
Copy link
Member

Please check 😭

I have manually added you as a contributor to the 5.3.7 release notes.

@ShindongLee
Copy link

ShindongLee commented May 13, 2021

Co-authored-by: hojongs hojong.jjh@gmail.com
Co-authored-by: bjh970913 bjh970913@gmail.com


Are you one of those listed co-authors? If so, which one?

Thanks !
@sbrannen
I'm the one who made a PR, and @hojongs & @bjh970913 are my teammates who helped me a lot for debugging and writing the test codes. Acutually I put them as co-authors. If you don't mind can you list them too? Thank you very much.

@sbrannen
Copy link
Member

Thanks !

You're welcome.

I'm the one who made a PR,

OK. I now see that you're listed as the author of commit 07ba957.

So perhaps the script that generates our release notes did not automatically include you as a contributor since that commit referenced the original issue instead of your PR. But I am merely speculating.

@snicoll, can you perhaps explain why that happened?

and hojongs & bjh970913 are my teammates who helped me a lot for debugging and writing the test codes. Acutually I put them as co-authors. If you don't mind can you list them too? Thank you very much.

Sure. I'll add them to the release notes, too.

Can you please confirm that their GitHub handles are @hojongs and @bjh970913?

@ShindongLee
Copy link

@sbrannen
Yes their ids are right.
Thank you for maintaining great framework. Our back-end team develops every server with Spring. We will try to contribute again if we have another chance. Thanks!

@snicoll
Copy link
Member

snicoll commented May 15, 2021

@snicoll, can you perhaps explain why that happened?

The tool does not parse commit messages at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Projects
None yet
Development

No branches or pull requests

5 participants