Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MariaDB to the supported database products for procedures and functions #25811

Closed
queueseven opened this issue Sep 24, 2020 · 2 comments
Closed
Assignees
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone

Comments

@queueseven
Copy link

queueseven commented Sep 24, 2020

After switching the database driver from mysql-connector-java to mariadb-java-client in one of our applications, stored procedures called with SimpleJdbcCall no longer worked and failed with an exception like java.sql.SQLSyntaxErrorException: Incorrect number of arguments for PROCEDURE foo.bar; expected 12, got 0.

After some investigation I noticed that the CallMetaDataProviderFactory has a list called supportedDatabaseProductsForProcedures (which contains MySQL, but not MariaDB) so accessProcedureColumnMetaData was set to false and initializeWithProcedureColumnMetaData was not called on the CallMetaDataProvider; thus no parameters where added to the procedure call, resulting in the SQLSyntaxErrorException.

So I think MariaDB should be added to the supportedDatabaseProductsForProcedures.

@jhoeller jhoeller self-assigned this Sep 24, 2020
@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement labels Sep 24, 2020
@jhoeller jhoeller added this to the 5.2.10 milestone Sep 24, 2020
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Sep 24, 2020
@jhoeller
Copy link
Contributor

As with #24443, we're going to add this to 5.2.x (5.2.10) and also backport it to 5.1.x (5.1.19). Thanks for raising it!

@jhoeller
Copy link
Contributor

As pointed out in 392ad09, we should add MariaDB to supportedDatabaseProductsForFunctions (since MySQL is also there).

jhoeller added a commit that referenced this issue Sep 25, 2020

Verified

This commit was signed with the committer’s verified signature.
blink1073 Steven Silvester
…ctions

Closes gh-25811
@jhoeller jhoeller changed the title Add MariaDB to the list of supported database products for procedures Add MariaDB to the supported database products for procedures and functions Sep 25, 2020
@jhoeller jhoeller reopened this Sep 25, 2020
zx20110729 pushed a commit to zx20110729/spring-framework that referenced this issue Feb 18, 2022

Verified

This commit was signed with the committer’s verified signature.
blink1073 Steven Silvester
…ctions

Closes spring-projectsgh-25811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants