Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize String argument resolution in MessageTag #25809

Closed
jhoeller opened this issue Sep 23, 2020 · 0 comments
Closed

Optimize String argument resolution in MessageTag #25809

jhoeller opened this issue Sep 23, 2020 · 0 comments
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.2.10

Comments

@jhoeller
Copy link
Contributor

MessageTag.resolveArguments contains old logic for checking a single String array element which seems to be dead code since a String element can never be an array itself, making all the differentiation pointless since we'll always return the given String anyway. Streamlining this towards a straight return of the original String array is not only easier to read but also avoids wasting CPU cycles.
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Sep 23, 2020
@jhoeller jhoeller added this to the 5.2.10 milestone Sep 23, 2020
@jhoeller jhoeller self-assigned this Sep 23, 2020
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Oct 16, 2020
Closed
jhoeller added a commit that referenced this issue Oct 16, 2020
@jhoeller
Optimize String argument resolution in MessageTag
f49e0e3 
Closes gh-25809

(cherry picked from commit d9da663)
zx20110729 pushed a commit to zx20110729/spring-framework that referenced this issue Feb 18, 2022
@jhoeller @zx20110729
Optimize String argument resolution in MessageTag
e853924 
Closes spring-projectsgh-25809

(cherry picked from commit d9da663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.10
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues