Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid repeated Charset resolution in MimeType #25808

Closed
jhoeller opened this issue Sep 23, 2020 · 0 comments
Closed

Avoid repeated Charset resolution in MimeType #25808

jhoeller opened this issue Sep 23, 2020 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.2.10

Comments

@jhoeller
Copy link
Contributor

Along the lines of the toString() caching in #22340, we can also cache the resolved Charset instance in MimeType, in particular for repeated getCharset() calls in if conditions (which are quite common in our converter implementations).
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Sep 23, 2020
@jhoeller jhoeller added this to the 5.2.10 milestone Sep 23, 2020
@jhoeller jhoeller self-assigned this Sep 23, 2020
jhoeller added a commit that referenced this issue Sep 25, 2020
@jhoeller
Avoid repeated Charset resolution in MimeType
c044008 
Closes gh-25808
@sbrannen sbrannen mentioned this issue Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.10
Development

No branches or pull requests
1 participant
@jhoeller