-
Notifications
You must be signed in to change notification settings - Fork 38.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PropertiesLoaderSupport should ignore socket/connect exceptions as well #25717
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
status: backported
An issue that has been backported to maintenance branches
type: enhancement
A general enhancement
Milestone
Comments
Good point, and I would go as far as ignoring any |
jhoeller
added a commit
that referenced
this issue
Sep 7, 2020
engimatic
pushed a commit
to engimatic/spring-framework
that referenced
this issue
Sep 29, 2020
… as well Closes spring-projectsgh-25717 (cherry picked from commit 613b05d)
zx20110729
pushed a commit
to zx20110729/spring-framework
that referenced
this issue
Feb 18, 2022
… as well Closes spring-projectsgh-25717 (cherry picked from commit 613b05d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
status: backported
An issue that has been backported to maintenance branches
type: enhancement
A general enhancement
Affects: 5.2.3-RELEASE
I am running on windows, trying to load properties from a shared network folder like \\remotehost\sharedfolder\common.properties, with
ignoreResourceNotFound
is set totrue
. If the property file is there, everything works, but in case the file is missing, loading fails with this somehow misleading exception:This error is very similar for example to this one in bitbucket issue. My simplistic view is, that
ConnectException
could be ignored, but I am not sure, what this change could break.If adding
ConnectException
to the ignore list is not possible,PropertiesLoaderSupport
could be made more flexible so we could override its behaviour. Now, all the important fields likelocations
are not accessible to an ancestor class as well asPropertiesLoaderUtils.fillProperties()
is not visible. If the loader would like to be super user friendly, it would also allow somehow to set timeout onURLConnection
throughUrlResource.getInputStream()
.The text was updated successfully, but these errors were encountered: