Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce mechanism to discover whether a reactive type registered in ReactiveAdapterRegistry uses deferred computation #24995

Closed
mp911de opened this issue Apr 30, 2020 · 0 comments
Closed

Introduce mechanism to discover whether a reactive type registered in ReactiveAdapterRegistry uses deferred computation #24995

mp911de opened this issue Apr 30, 2020 · 0 comments
Assignees
@rstoyanchev
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.2.7

Comments

@mp911de
Copy link
Member

mp911de commented Apr 30, 2020

It would make sense to describe whether a type registered in ReactiveAdapterRegistry uses deferred computation. Deferred types are Publisher types, RxJava types and Kotlin's flow. Non-deferred types (eager computation) are which act as Future or Promise.

Background is that Spring Data uses ReactiveAdapterRegistry to determine a stack that is used to implement a repository interface. An issue comes into play when a repository uses @Async in combination with CompletableFuture. These methods are typically implemented using the imperative stack and calls are offloaded to a thread pool. Since the registry lists CompletionStage/CompletableFuture types, future types are considered to be reactive ones.

Related issue: https://jira.spring.io/browse/DATAJPA-1710
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 30, 2020
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 30, 2020
@jhoeller jhoeller added this to the 5.2.7 milestone Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.7
Development

No branches or pull requests
4 participants
@rstoyanchev @mp911de @jhoeller @spring-projects-issues