Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation searches potentially synthesize annotations unnecessarily #24861

Closed
1 task done
sbrannen opened this issue Apr 3, 2020 · 3 comments
Closed
1 task done

Annotation searches potentially synthesize annotations unnecessarily #24861

sbrannen opened this issue Apr 3, 2020 · 3 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: regression A bug that is also a regression
Milestone
5.2.6

Comments

@sbrannen
Copy link
Member

sbrannen commented Apr 3, 2020 •
edited
Loading

Overview

Prior to Spring Framework 5.2, some of our annotation utilities would not synthesize an annotation if it was already synthesized or not synthesizable.

It appears that we may have lost this functionality with the introduction of the new MergedAnnotations API. This issue is therefore labeled as a potential regression.

Deliverables

  • Determine if annotations are synthesized unnecessarily and decide where to go from there.
@sbrannen sbrannen added type: regression A bug that is also a regression in: core Issues in core modules (aop, beans, core, context, expression) labels Apr 3, 2020
@sbrannen sbrannen added this to the 5.2.6 milestone Apr 3, 2020
@sbrannen sbrannen self-assigned this Apr 3, 2020
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Apr 20, 2020
@sbrannen
Test status quo for unnecessary annotation synthesis
fde329b 
See spring-projectsgh-24861
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Apr 20, 2020
@sbrannen
Avoid synthesizing annotations unnecessarily
bcb3019 
Closes spring-projectsgh-24861
@sbrannen
Copy link
Member Author

Current work on this issue can be viewed here: master...sbrannen:issues/gh-24861-unnecessary-annotation-synthesis

@sbrannen
Copy link
Member Author

Reopening to ensure that annotations with attributes are also not unnecessarily synthesized.

@sbrannen sbrannen reopened this Apr 22, 2020
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Apr 22, 2020
@sbrannen
Avoid synthesizing annotations unnecessarily
5196149 
Closes spring-projectsgh-24861
@sbrannen
Copy link
Member Author

Current work on the second attempt for this issue can be viewed here: master...sbrannen:issues/gh-24861-unnecessary-annotation-synthesis-v2

@jhoeller jhoeller mentioned this issue Apr 23, 2020
Closed
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Apr 23, 2020
@sbrannen
Avoid synthesizing annotations unnecessarily
f855c55 
Closes spring-projectsgh-24861
@sdeleuze sdeleuze mentioned this issue Apr 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: regression A bug that is also a regression
Projects
None yet
Milestone
5.2.6
Development

No branches or pull requests
1 participant
@sbrannen