Skip to content

Spring JavaMailSenderImpl does not show proper message when recipient list is empty [SPR-17540] #22072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Nov 27, 2018 · 1 comment
Closed

Spring JavaMailSenderImpl does not show proper message when recipient list is empty [SPR-17540] #22072

spring-projects-issues opened this issue Nov 27, 2018 · 1 comment
Assignees
@jhoeller
Labels
status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.1.4

Comments

@spring-projects-issues
Copy link
Collaborator

Jebil opened SPR-17540 and commented

org.springframework.mail.javamail.JavaMailSenderImpl does not show proper message when recipient list is empty.

Currently it just throws NPE, which is hard to debug for beginners.

Referenced from: pull request #2029, and commits 16e9b83, 2efac5a, 191a2d3

Backported to: 5.0.12, 4.3.22
@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

I've addressed this slightly differently, passing an empty Address array into sendMessage if we received null there and triggering the regular SendFailedException (with a "no recipient addresses" message) from the mail provider that way.

@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.4 milestone Jan 11, 2019
This was referenced Jan 11, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.1.4
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues