Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractJackson2HttpMessageConverter incorrectly logs at WARN level after upgrading to Jackson 2.9 [SPR-16947] #21486

Closed
spring-projects-issues opened this issue Jun 17, 2018 · 3 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jun 17, 2018

Mark Chesney opened SPR-16947 and commented

The verbiage of exception messages changed from "Can not find" to "Cannot find" in Jackson 2.9 with PR #1682

e.g.

WARN o.s.h.c.j.MappingJackson2HttpMessageConverter : Failed to evaluate Jackson deserialization for type [[collection type; class com.google.common.collect.ImmutableList...


Affects: 4.3.18, 5.0.7

Issue Links:

Referenced from: pull request #1859

Backported to: 4.3.19

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Good catch! I'll backport this to 5.0.8 and 4.3.19 ASAP.

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

I've also adapted our analogous detection logic in org.springframework.messaging.converter.MappingJackson2MessageConverter accordingly (which currently is a duplicate of AbstractJackson2HttpMessageConverter.logWarningIfNecessary since there is no proper place to reuse it from).

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

It turns out that we can simplify this to just a "Cannot find" check on Spring Framework 5.1 since we formally require Jackson 2.9+ now. In the backports, we'll have to check for both variants (even if we technically require Jackson 2.9+ in a few places for other reasons already).

@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.8 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants