Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractRequestLoggingFilter.isIncludeHeaders() is accidentally public [SPR-16881] #21420

Closed
spring-projects-issues opened this issue May 29, 2018 · 1 comment
Closed

AbstractRequestLoggingFilter.isIncludeHeaders() is accidentally public [SPR-16881] #21420

spring-projects-issues opened this issue May 29, 2018 · 1 comment
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.0.7

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented May 29, 2018 •
edited
Loading

Juergen Hoeller opened SPR-16881 and commented

The includeHeaders property introduced in #18818 accidentally has a public getter whereas all other such properties on AbstractRequestLoggingFilter are protected.

Affects: 4.3.17, 5.0.6

Issue Links:

Referenced from: pull request #1838, and commits a2d7cc7, c754232

Backported to: 4.3.18
@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Fixed as part of a slightly wider revision on master; I'll backport this to 5.0.x and 4.3.x ASAP.

@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.7 milestone Jan 11, 2019
This was referenced Jan 11, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.0.7
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues