Concurrent result may be missed due to a race condition in MockMvc [SPR-16648]

[spring-projects-issues]

Andy Wilkinson opened SPR-16648 and commented

From Rossen on the referenced Spring Boot issue:

The async value is set on MvcResult through an interceptor, and that releases perform(asyncDispatch(..)) to proceed. However there is a small window of time after that until the concurrentResult is set, see lines 316 vs 325. If you put a break on line 325 to slow down setting the concurrentResult, the main thread proceeds with the asyncDispatch and then hangs upon entering in the controller method.

It looks like at some point we did have a latch to wait for the dispatch, but that was removed in a follow-up fix. Not really sure how it went undetected for so long. Maybe the window is small enough, or perhaps something about this test that makes it a little more likely to fail.

I've been unable to reproduce the failure on macOS, but our Concourse CI environment (Docker container running on Linux) has been affected reasonably frequently, IIRC. That's the environment in which I captured the thread dump in the referenced Boot issue.

---

Affects: 4.3.14, 5.0.4

Reference URL: spring-projects/spring-boot#12609

Issue Links:

• Spring MVC Test can fail to obtain async result due to timing issue [SPR-11516] #16141 Spring MVC Test can fail to obtain async result due to timing issue
• ClassCastException in TestDispatcherServlet [SPR-16695] #21236 ClassCastException in TestDispatcherServlet

Referenced from: commits 6e4bbac, f9e6ea5

Backported to: 4.3.15