TransactionTemplate inherits equals()/hashCode() from DefaultTransactionDefinition [SPR-16572]

[spring-projects-issues]

Arne Vandamme opened SPR-16572 and commented

Two TransactionTemplate instances are considered equal purely based on their DefaultTransactionDefinition properties, without taking the actual configured PlatformTransactionManager into account.

Cause: the TransactionTemplate class inherits equals() and hashCode() from DefaultTransactionDefinition. I would assume the actual PlatformTransactionManager should also be taken into account.

---

Affects: 4.3.14, 5.0.4

Referenced from: pull request #1736, and commits b1295d0, df80614

Backported to: 4.3.15

[spring-projects-issues]

Arne Vandamme commented

PR added with proposed change: #1736

[spring-projects-issues]

Juergen Hoeller commented

We generally don't expect TransactionTemplate instances to get compared for equality, but point taken, since it inherits transaction definition equality semantics it should enforce the same transaction manager when compared to another TransactionTemplate instance.

[spring-projects-issues]

Arne Vandamme commented

Actually it is indeed not so much about deliberately comparing them for equality. But it has the nasty side effect you can't build for example a HashSet of the different TransactionTemplate beans. You do not get the result you would expect. That's also how I found out about this.

[spring-projects-issues]

Juergen Hoeller commented

Alright, fixed in master for 5.0.5 now; I'll backport this to 4.3.15 ASAP.

[spring-projects-issues]

Arne Vandamme commented

Great, thanks! (as well for the implementation feedback)