Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebApplicationContextFacesELResolver#isReadOnly always return false [SPR-16543] #21086

Closed
spring-projects-issues opened this issue Feb 28, 2018 · 1 comment
Closed

WebApplicationContextFacesELResolver#isReadOnly always return false [SPR-16543] #21086

spring-projects-issues opened this issue Feb 28, 2018 · 1 comment
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.0.5

Comments

@spring-projects-issues
Copy link
Collaborator

Igor opened SPR-16543 and commented

Is it correct behaviour that org.springframework.web.jsf.el.WebApplicationContextFacesELResolver#isReadOnly
always return false?

Affects: 4.3.14, 5.0.4

Reference URL: https://github.com/spring-projects/spring-framework/blob/master/spring-web/src/main/java/org/springframework/web/jsf/el/WebApplicationContextFacesELResolver.java#L155

Referenced from: commits 4781627, 3e6cfb7

Backported to: 4.3.15
@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

The return value is effectively being ignored if the property is not marked as resolved, so the fallback value doesn't really matter... That said, when we resolve the WebApplicationContext there, we should actually return true since a setValue call will never apply to it.

@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.5 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.0.5
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues