Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid String concatenation for not-null assertion in BeanProperty/DirectFieldBindingResult [SPR-16455] #21000

Closed
spring-projects-issues opened this issue Feb 1, 2018 · 0 comments
Closed

Avoid String concatenation for not-null assertion in BeanProperty/DirectFieldBindingResult [SPR-16455] #21000

spring-projects-issues opened this issue Feb 1, 2018 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.0.4

Comments

@spring-projects-issues
Copy link
Collaborator

Juergen Hoeller opened SPR-16455 and commented

BeanPropertyBindingResult and DirectFieldBindingResult both come with an assertion for a not-null target object. In both cases, the assertion concatenates the object name into the message which creates unnecessary performance overhead for the regular code path.

Affects: 4.3.14, 5.0.3

Referenced from: commits 9c069f6, 9926b68

Backported to: 4.3.15
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.4 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.0.4
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues