Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@JmsListener concurrency property is ignored if DefaultJmsListenerContainerFactory#concurrency is set [SPR-16338] #20885

Closed
spring-projects-issues opened this issue Jan 2, 2018 · 1 comment
Closed

@JmsListener concurrency property is ignored if DefaultJmsListenerContainerFactory#concurrency is set [SPR-16338] #20885

spring-projects-issues opened this issue Jan 2, 2018 · 1 comment
Assignees
@snicoll
Labels
in: messaging Issues in messaging modules (jms, messaging) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.0.3

Comments

@spring-projects-issues
Copy link
Collaborator

Cameron Mayfield opened SPR-16338 and commented

We are noticing that the concurrency property on a specific @JmsListener annotation is overwritten by the DefaultJmsListenerContainerFactory concurrency value which is set using the spring.jms.listener.concurrency property. This appears to occur in DefaultJmsListenerContainerFactory#initializeContainer.

We were hoping to override the concurrency for a specific @JmsListener while leaving the others on the default.

Affects: 4.3.13

Referenced from: commits 0747cd6, 42dfa40

Backported to: 4.3.14
@spring-projects-issues
Copy link
Collaborator Author

Stéphane Nicoll commented

Good catch, this is due to initializeContainer that is applied after the settings of the endpoint have been applied. Flipping that with the setupListenerContainer call in createListenerContainer should be enough to fix the issue.

Ideally, we should have had a test to exercise this behaviour,

@spring-projects-issues spring-projects-issues added type: bug A general bug in: messaging Issues in messaging modules (jms, messaging) status: backported An issue that has been backported to maintenance branches labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.3 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: messaging Issues in messaging modules (jms, messaging) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.0.3
Development

No branches or pull requests
2 participants
@snicoll @spring-projects-issues