Unnecessary file system access in SimpleMetadataReaderFactory.getMetadataReader [SPR-16281]

[spring-projects-issues]

Rex Hoffman opened SPR-16281 and commented

Instead of eagerly checking the file exists with "if (!resource.exists())" perhaps move the logic into the metadata reader only attempt the rewrite if the access has failed with the passed in name?

We can provide a patch if needed.

---

Affects: 4.3.6, 4.3.14

Reference URL: https://github.com/spring-projects/spring-framework/blob/master/spring-core/src/main/java/org/springframework/core/type/classreading/SimpleMetadataReaderFactory.java#L80-L90

Issue Links:

• PropertySourcesPlaceholderConfigurer can not ignore resource if not found [SPR-16334] #20881 PropertySourcesPlaceholderConfigurer can not ignore resource if not found

Referenced from: commits 7ad69bf, 3368dca

Backported to: 4.3.14

[spring-projects-issues]

Brian Toal commented

Good evening,

@Juergen Hoeller any thoughts on timelines of a fix?

[spring-projects-issues]

Rex Hoffman commented

Brain, see the fix version:

Fix Version/s:
4.3.14, 5.0.3

[spring-projects-issues]

Brian Toal commented

Apologies Juergen, I missed the "fixed version" and wasn't aware when that version is available. Rex filled me in on and offline.

Thanks for looking at this!

[spring-projects-issues]

Juergen Hoeller commented

We're optimistically trying the standard resource path now, catching FileNotFoundException now and only trying the inner class variant then.

[spring-projects-issues]

Rex Hoffman commented

This fix looks perfect for our use case. Would you like us to get timings, or is the feedback sufficient?