Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect SpEL example in reference documentation [SPR-16111] #20659

Closed
spring-projects-issues opened this issue Oct 25, 2017 · 2 comments
Closed
Assignees
Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Sviatoslav Hryb opened SPR-16111 and commented

Spring Framework Reference Core Technologies https://docs.spring.io/spring/docs/current/spring-framework-reference/pdf/core.pdf contains incorrect code fragment in section 4.5.6. Methods.
The incorrect code fragment is: ```
// string literal, evaluates to "bc"
String c = parser.parseExpression("'abc'.substring(2, 3)").getValue(String.class);

Because string literal, evaluates to "c" but not to "bc"

Referenced from: commits f965123, 5867ea0

Backported to: 4.3.13

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Good catch, I've fixed this towards substring(1, 3).

FWIW, this is not a 'critical' framework bug. We consider such documentation glitches as minor tasks only.

@spring-projects-issues
Copy link
Collaborator Author

Sviatoslav Hryb commented

Thanks!

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches type: documentation A documentation task labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

2 participants