Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport s/s/m/j/o/s/m/w/MockPart.java from 5.x to 4.3.x [SPR-15854] #20409

Closed
spring-projects-issues opened this issue Aug 9, 2017 · 1 comment
Assignees
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Aug 9, 2017

Laurent Perez opened SPR-15854 and commented

Currently s/s/m/j/o/s/m/w/MockPart.java from 5.x to 4.3.x is 5.x only
In 4.3.x there is MockHttpServletRequest.java#addPart(Part p), but no mock for Part
It'd be useful to be able to reuse MockPart in 4.3.x

Context : wrote a test case in a non Spring Web project (bare Servlets + Mockito) but used Spring Test mocks in test dependencies. Had to copy paste MockPart from 5.x without Nullable/Assert to get the mock.


Affects: 4.3.10

Issue Links:

Referenced from: commits 87df393, ea01c41

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

I've prepared MockPart in master, revisiting its constructors for consistent byte array parameters. I'll backport it to 4.3.x tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants