Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListenableScheduledFuture support to TaskScheduler [SPR-13407] #17987

Closed
spring-projects-issues opened this issue Aug 30, 2015 · 3 comments
Closed
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Aug 30, 2015

Kevin Conaway opened SPR-13407 and commented

Juergen Hoeller what are your thoughts on adding listenable support for the TaskScheduler interface? I'm envisioning an AsyncListenableTaskScheduler interface that has scheduleListenableXXX methods that mirror those in TaskScheduler (similar to AsyncListenableTaskExecutor -> TaskExecutor)

The use case here is to register callbacks that fire for every execution of the scheduled task.

I'm happy to submit a PR for this if you think it would be worthwhile. I have written an implementation for for ListenableScheduledFuture<?> scheduleListenable(Runnable task, Trigger trigger); that we're using here but I would like to get a full featured version in to core if possible


Affects: 4.2 GA

Issue Links:

@spring-projects-issues
Copy link
Collaborator Author

Kevin Conaway commented

One thing thats important to me is that the callbacks fire after the job is rescheduled again. This allows access to the underlying future so that the callback knows when the job will fire again (for reporting or other use cases)

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Kevin Conaway, this is still in consideration for 4.3... Could you share your trigger-based implementation for a start?

Juergen

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.x Backlog milestone Jan 11, 2019
@jhoeller
Copy link
Contributor

This approach got superseded by the deprecation of ListenableFuture in #27780.

@jhoeller jhoeller added the status: superseded An issue that has been superseded by another label Jul 13, 2023
@jhoeller jhoeller removed this from the 6.x Backlog milestone Jul 13, 2023
@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants