Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
9
contributors
Commits on Feb 16, 2021
Commits on Feb 17, 2021
-
-
Support cookie w/ only Expires attribute in MockHttpServletResponse
Prior to this commit, MockHttpServletResponse only included the Expires attribute in the generated Cookie header if the Max-Age attribute had also been set. This commit supports including the Expires attribute in the generated Cookie Header even when the Max-Age attribute has not been set. Closes gh-26558
-
Fix ResourceUrlProvider handler auto-detection
Prior to this commit, `ResourceUrlProvider` would listen and consider all `ContextRefreshedEvent` and use the given context to detect `SimpleUrlHandlerMapping`. This could lead to situations where a `ResourceUrlProvider` uses another application context than its own (in a parent/child context setup) and detect the wrong set of handlers. Because `ResourceUrlProvider` locks itself once the auto-detection is done, we need to ensure that it considers only events sent by its application context. Fixes gh-26562
Commits on Feb 22, 2021
-
Support load-time weaving for @component classes again
Since Spring Framework 5.2, the LoadTimeWeaver no longer weaves bean classes annotated with @component. This is a regression caused by the changes in 40c6213, stemming from the fact that any class annotated or meta-annotated with @component is considered to be a candidate configuration class in 'configuration lite' mode (i.e., a class without the @configuration annotation and without any @bean methods) and therefore now has its class eagerly loaded. This results in the class being loaded before the LoadTimeWeaver has a chance to weave it. This commit fixes this regression by explicitly avoiding eager class loading for any 'lite' @configuration or @component class without @bean methods. Closes gh-26199
Commits on Feb 25, 2021
-
Correctly set auto-growing array's element
Prior to this commit, the implementation of processKeyedProperty() in AbstractNestablePropertyAccessor resulted in a `java.lang.IllegalArgumentException: array element type mismatch` when the property expression had more than one property key and the last key should cause the array to grow automatically. For example, given a property `int[][] multiArray` and property expression `multiArray[1][3]`, the `processKeyedProperty()` method created a new array object and assigned it to `multiArray`; whereas, the new array object should have be assigned to `multiArray[1]`. This commit fixes this issue. Closes gh-26600
-
getResource can throw IllegalArgumentException
Class.getResource, ClassLoader.getResource, and ClassLoader.getSystemResource will throw IllegalArgumentException if a malformed URL is provided to them. According to its javadoc, resolveURL should return null if not resolvable, so catch the IllegalArgumentException and return null. Closes gh-26574
-
Fix handling of file: paths to non-existent files
For setAsText, if the text argument is a file: URL for a path that does not exist, Paths.get(text) is called where text is a file: URL, which doesn't work - the result is an InvalidPathException. To fix this issue, also check that the resource isn't a file before calling Paths.get(). That way, resources that are files skip to the other branch. Closes gh-26575
-
Commits on Feb 26, 2021
Commits on Mar 2, 2021
-
Ensure local @crossorigin maxAge overrides global value
Prior to this commit, a method-level @crossorigin maxAge value did not override a class-level @crossorigin maxAge value. This contradicts the Javadoc for @Crossorgin which states the following. For those attributes where only a single value can be accepted such as allowCredentials and maxAge, the local overrides the global value. This commit ensures that a method-level @crossorigin maxAge value overrides a class-level @crossorigin maxAge value. Closes gh-26619
Commits on Mar 4, 2021
Commits on Mar 8, 2021
Commits on Mar 9, 2021
Commits on Mar 10, 2021
Commits on Mar 11, 2021
-
Use ".RELEASE" suffix for releases on 5.2.x branch
This commit ensures that the release scripts generate a ".RELEASE" suffixed release version, since the 5.2.x branch is still using this naming scheme. See https://github.com/spring-io/concourse-java-scripts#get_next_release See gh-26659
Commits on Mar 12, 2021
Commits on Mar 16, 2021
-
Fix release pipeline for Maven Central publication
This commit fixes the missing pieces in our Maven Central publication pipeline. Our first attempt at releasing with it showed a few problems: * the promote task did not have the artifacts downladed with the artifactory repository * we applied the wrong Sonatype credentials to the task * the github changelog task would fail because of docker rate limiting since we were not using the right type of resource, which is configured with the proper caching mechanism See gh-26654
Commits on Mar 18, 2021
-
Honor class-level @DirtiesContext if test class is disabled via SpEL
Prior to this commit, if a test class annotated with @DirtiesContext and @EnabledIf/@DisabledIf with `loadContext = true` was disabled due to the evaluated SpEL expression, the ApplicationContext would not be marked as dirty and closed. The reason is that @EnabledIf/@DisabledIf are implemented via JUnit Jupiter's ExecutionCondition extension API which results in the entire test class (as well as any associated extension callbacks) being skipped if the condition evaluates to `disabled`. This effectively prevents any of Spring's TestExecutionListener APIs from being invoked. Consequently, the DirtiesContextTestExecutionListener does not get a chance to honor the class-level @DirtiesContext declaration. This commit fixes this by implementing part of the logic of DirtiesContextTestExecutionListener in AbstractExpressionEvaluatingCondition (i.e., the base class for @EnabledIf/@DisabledIf support). Specifically, if the test class for an eagerly loaded ApplicationContext is disabled, AbstractExpressionEvaluatingCondition will now mark the test ApplicationContext as dirty if the test class is annotated with @DirtiesContext. Closes gh-26694
There are no files selected for viewing